jsonnet-libs icon indicating copy to clipboard operation
jsonnet-libs copied to clipboard

Published 20 hours ago • verified publisher icon grafana

apache camel 3 mixin

Open alainpham opened this issue 3 years ago • 1 comments

This PR is to add Apache Camel 3 dashboards as a Grafana Integration.

The dashboard is based on metrics generated by the Micrometer Prometheus instrumentation that is standard across all flavors of Apache Camel (Spring Boot, Quarkus, Camel K)

Screen shot

alainpham avatar Aug 24 '22 07:08 alainpham

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 24 '22 07:08 CLAassistant

Can we merge this? @alainpham

gloriasc avatar Jan 09 '23 14:01 gloriasc

If you give me this week I can make the changes suggested by @rgeyer. Thanks

alainpham avatar Jan 09 '23 14:01 alainpham

If you give me this week I can make the changes suggested by @rgeyer. Thanks

Definitely! Thanks for looking into it!

gloriasc avatar Jan 10 '23 09:01 gloriasc

Can we merge this?

gloriasc avatar Apr 20 '23 09:04 gloriasc

Hi I have added the requested template variables and optimized the dashboard for a kubernetes deployment and eventual log correlation.

This can be merged now.

alainpham avatar May 06 '23 13:05 alainpham

@gloriasc there has been some changes in the naming convention of the Apache Camel prometheus exporter. I have updated the dashboard to take it into account in the latest commit. Could that be pushed to review?

alainpham avatar Jul 05 '23 06:07 alainpham

I'll add it to our board!

gloriasc avatar Jul 05 '23 08:07 gloriasc

@gloriasc there has been some changes in the naming convention of the Apache Camel prometheus exporter. I have updated the dashboard to take it into account in the latest commit. Could that be pushed to review?

@alainpham This still LGTM. I can't see what changed with the naming conventions tho, there is no follow-up commit.

I'd be comfortable merging this as is (should have done so in May 🤦‍♂️), but want to make sure that those changes are accounted for. Can you point out what has changed with the exporter, and the related changes here?

rgeyer avatar Jul 07 '23 17:07 rgeyer

@rgeyer here are the main diffs from the upstream dashboard. As you have suggested I have referenced it using json bundler.

https://github.com/alainpham/app-archetypes/commit/5618dc283d040cc59df5569d0c1181bea3f88d34

alainpham avatar Jul 11 '23 07:07 alainpham

@rgeyer here are the main diffs from the upstream dashboard. As you have suggested I have referenced it using json bundler.

alainpham/app-archetypes@5618dc2

Looks good! I'm going to go ahead and merge this. Thank you!

rgeyer avatar Jul 11 '23 17:07 rgeyer