jsonnet-libs icon indicating copy to clipboard operation
jsonnet-libs copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Consul-mixin: Improvements from linting

Open rgeyer opened this issue 3 years ago • 2 comments

Make job template var multi-select Aggregate server queries by instance Use $__rate_interval throughout

rgeyer avatar Jun 08 '22 20:06 rgeyer

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 15 '22 17:06 CLAassistant

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 04:09 stale[bot]

Reopening this as these changes (and some more) are needed for cloud-onboarding#3417

Currently the consul and hcp-consul mixins are pointing at a specific commit that is in this unmerged PR. There are also additional changes that should be done to pass the CI.

  1. We should reopen this PR so that the jsonnetfile.json for consul and hcp-consul can point to version master
  2. We should add the additional fixes that @Dasomeone suggested in cloud-onboarding#3417 so that this mixin passes the CI

CC @Dasomeone

fabienne-m avatar Mar 29 '23 10:03 fabienne-m