[tempo-distributed] feat: add overridable max_span_attr_byte for distributor

[dd84ai]

Description

adding overridable max_span_attr_byte for distributor config https://grafana.com/docs/tempo/latest/configuration/#distributor as according to documentation, this parameter is configurable

Motivation:

It is desirable to be overridable to higher value like 20'0000 for the sake of seeing larger SQL queries in Tracing attributes received from opentelemetry instrumentation psycopg2 auto instrumentation in python https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-psycopg For my team it is important feature to have regardless of extra involved RAM costs and disk usages and etc.

Comment:

I already checked it works in deployment using tempo-distributed-1.35.0 version

distributor:
  max_span_attr_byte: 20480

becomes visible in /conf/tempo.yaml inside distributor and traces appear having more full SQL queries attributes as desired.

Intended usage

in your values.yaml use like:

distributor:
  config:
    max_span_attr_byte: 20480

[CLAassistant]

All committers have signed the CLA.

[QuentinBisson]

@dd84ai i think this is good to have. Can you resolve the conflicts?

[QuentinBisson]

I see this has been added already via .Values.distributor.config.max_attribute_bytes. Do you still see value in this PR?

[dd84ai]

I see this has been added already via .Values.distributor.config.max_attribute_bytes. Do you still see value in this PR?

@QuentinBisson , I see since 2.8.0 grafana https://github.com/grafana/tempo/releases/tag/v2.8.0-rc.0 the attribute was renamed to max_attribute_bytes

[CHANGE] BREAKING CHANGE Enforce max attribute size at event, link, and instrumentation scope. Make config per-tenant.
Renamed max_span_attr_byte to max_attribute_bytes #4633 (@ie-pham)

and the current version of tempo-distributed is indeed having ability to define max_attribute_bytes for distributor Therefore this PR has no longer value and I close it.

[dd84ai]

@QuentinBisson also bless you for giving a check and sorting out, even if the result ended in closing of it. Nice to see some movement to be present now. Thank you. ^_^

[QuentinBisson]

I just became a maintainer to help out and I just started checking out old PRs :) thanks for your nice message