helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[grafana-sampling] metrics generation configuration

Open maximelaboisson opened this issue 9 months ago • 6 comments
trafficstars

Adding metrics flush interval, expiration, and buckets configuration for metrics generation

maximelaboisson avatar Feb 05 '25 15:02 maximelaboisson

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 05 '25 15:02 CLAassistant

👋 I'm not sure if I'm tagging the right people here since there's no codeowner for this chart, but I can see from previous PR that @petewall & @rlankfo reviewed most of them 😄 I'm wondering if I did something wrong since some CI checks do not seem to be running? Is there anything else missing for me to be able to ask for review?

maximelaboisson avatar Feb 06 '25 08:02 maximelaboisson

hey @maximelaboisson, thanks for the PR! I'll re-open this and see if I can approve and run the workflows.

rlankfo avatar Feb 07 '25 18:02 rlankfo

Just commenting that this is a highly valuable change and would love to see it merged. I am currently hacking around the lack of metrics expiration with a helm hook patching the configmap. Expiration is basically a required feature of metrics generation otherwise the cardinality implications make metrics generation unusable in larger workloads.

a-abella avatar Feb 28 '25 21:02 a-abella

Another PR was merged recently that enables configuration of the metric expiration value, #3613

a-abella avatar Mar 30 '25 06:03 a-abella

For some reasons I'm just seeing the notifications for the PR being reopened now 😅

In the end, I decided to just run a fork of the chart on my side since I ended up making more changes. I'm happy to fix this PR to make things work though if the maintainers think it's valuable?

maximelaboisson avatar Mar 30 '25 07:03 maximelaboisson