helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Add OCI registry support for all Helm charts

Open domolitom opened this issue 1 year ago • 4 comments

Some Helm charts, such as Loki, are not being pushed to an OCI registry because OCI support is missing in the update-helm-repo.yaml workflow, which is used for external releases.

Solution: This PR introduces a step that ensures Helm charts are also pushed to the GitHub Container Registry (GHCR) as part of the release process, providing OCI support for charts that were previously excluded.

domolitom avatar Oct 16 '24 07:10 domolitom

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 16 '24 17:10 CLAassistant

@Sheikh-Abubaker

domolitom avatar Oct 17 '24 07:10 domolitom

Thank you for the PR. The changes look very similar to an earlier PR https://github.com/grafana/helm-charts/pull/3115 (which got slipped from the final reviews). Could you help testing it?

narqo avatar Oct 21 '24 11:10 narqo

@narqo that is true. I didn't see the already open PR. Btw the PR https://github.com/grafana/helm-charts/pull/3115 needs to be edited, the workflow needs write permission to packages. I just added it into this PR.

domolitom avatar Oct 21 '24 12:10 domolitom