helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[grafana] Improve dashboards download script

Open xinity opened this issue 1 year ago • 6 comments

This PR aims at improving the logging experience of the dowload dashboards script to :

  • avoid leaking git token in the execution logs
  • add more information about which download is downloaded from wich source
  • output the curl error message if any

xinity avatar Oct 10 '24 07:10 xinity

Please bump the chart version, thanks!

jkroepke avatar Oct 10 '24 07:10 jkroepke

@jkroepke oups, missed this, done :)

xinity avatar Oct 10 '24 08:10 xinity

please fix CI failures and MR conflicts

jkroepke avatar Oct 14 '24 07:10 jkroepke

@jkroepke will squash to improve readability

xinity avatar Oct 14 '24 08:10 xinity

@xinity Please bump the chart version and sign DCO. Thank you.

zanhsieh avatar Oct 14 '24 16:10 zanhsieh

@zanhsieh too many commits but signed and fix :)

xinity avatar Oct 15 '24 08:10 xinity