helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[tempo-operator] Adds first implementation of tempo-operator helm-chart

Open suyash-811 opened this issue 1 year ago • 7 comments

Background: We were expressing interest in #3032 to create a helm-chart for tempo-operator. I started working on this a while ago, and i have an initial working version of the helm-chart.

I would however like to also get some help on certain open questions, which could help maintaining this chart easier in the future. (Questions listed below)

  1. How should we deal with CRDs? I have included them in the crds folder in the chart. However, often migrating to newer versions of the CRDs could be challenging. Any ideas on how to handle CRDs?
  2. This one would be for someone from the tempo-operator community (I'll link them in the PR later). The deployment contains some environment variables which specify image versions for several services(code block below). Do removing any of these ENV VARs cause the operator to behave differently?
          env:
          - name: RELATED_IMAGE_TEMPO
            value: docker.io/grafana/tempo:2.5.0
          - name: RELATED_IMAGE_TEMPO_QUERY
            value: docker.io/grafana/tempo-query:2.5.0
          - name: RELATED_IMAGE_TEMPO_GATEWAY
            value: quay.io/observatorium/api:main-2024-05-29-ca8d2de
          - name: RELATED_IMAGE_TEMPO_GATEWAY_OPA
            value: quay.io/observatorium/opa-openshift:main-2024-04-29-914c13f
          - name: RELATED_IMAGE_OAUTH_PROXY
            value: quay.io/openshift/origin-oauth-proxy:4.12

Looking forward to suggestions for improvements and collaborating on bringing this to release soon! 😄

(P.S. apologies if i missed out any details. This is my first PR here.)

suyash-811 avatar Sep 25 '24 21:09 suyash-811

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 25 '24 21:09 CLAassistant

I pushed a commit to fix problems with linting, but pushed without the signoff. Thus, had to rebase with a signoff again.

suyash-811 avatar Sep 26 '24 20:09 suyash-811

I made some more changes to ensure that the workflows are passing.

suyash-811 avatar Jan 31 '25 18:01 suyash-811

Hey @Sheikh-Abubaker I wanted to run my latest changes through the CI. I saw your name here on this PR and thought of asking you. Sorry if I need to approach someone else about this. Could you approve the workflows after reviewing my changes? Thanks and let me know if I missed out something.

suyash-811 avatar Feb 07 '25 21:02 suyash-811

Hey, i am trying to get this new chart released, and all the checks have passed. Could someone review this? I will be happy to work on any suggested changes. While the chart isnt perfect, i would like to get the chart released, to get more feedback and improvements from the community thanks

suyash-811 avatar Feb 25 '25 20:02 suyash-811

Hi @suyash-811 What is the plan to keep this chart up-to-date? E.g. a change in the operator, for example updating the tempo or gateway version, updating RBAC permissions, etc. will likely break the operator deployment via this helm chart if this chart is not kept in sync with the operator CSV.

Do you have automation around this? i.e. generate the helm manifests automatically from this folder: https://github.com/grafana/tempo-operator/tree/main/bundle/community/manifests?

andreasgerstmayr avatar May 19 '25 11:05 andreasgerstmayr

Do you have automation around this? i.e. generate the helm manifests automatically from this folder: https://github.com/grafana/tempo-operator/tree/main/bundle/community/manifests?

In the operator repo, we generate plain Kubernetes manifests for every release (example: https://github.com/grafana/tempo-operator/releases/download/v0.15.3/tempo-operator.yaml) - maybe we could run them through helmify to keep the chart up-to-date automatically?

andreasgerstmayr avatar May 19 '25 14:05 andreasgerstmayr