helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[tempo-distributed] feat: add cli flag for zone aware ingestion

Open KyriosGN0 opened this issue 1 year ago • 7 comments

like in mimir, we need to pass ingester.ring.instance-availability-zone when enabled zone aware ingestion FYI @zalegrala

KyriosGN0 avatar Jul 14 '24 08:07 KyriosGN0

I get the following when trying to pass that flag.

flag provided but not defined: -ingester.ring.instance-availability-zone

zalegrala avatar Jul 16 '24 19:07 zalegrala

@zalegrala weird, in our mimir we use this flag, but according to the Cortex Config it should be -ingester.availability-zone i'll try to compile in jsonnet since it also has a Zone Aware config

KyriosGN0 avatar Jul 16 '24 19:07 KyriosGN0

hm @zalegrala i looked into the jsonnet and they only set the env var availability_zone which corresponds to the -ingester.availability-zone cli flag according to the cortex docs, so i think its good enough.

KyriosGN0 avatar Jul 16 '24 20:07 KyriosGN0

Each database exposes different config flags, so we can't assume that because its exposed in mimir that it would be exposed in tempo. Have you had a chance to test this change?

zalegrala avatar Jul 17 '24 15:07 zalegrala

@zalegrala -ingester.availability-zone is equivalent to the env var set in the jsonnet file of Tempo, i'll try to deploy this locally in some KIND cluster to see that it recognizes the flag.

KyriosGN0 avatar Jul 17 '24 16:07 KyriosGN0

@zalegrala after taking another look in the jsonnet file i've realized i've missed other things in the chart (like services) i would also need to open PR to tempo itself to support this cli flag (or figure out how to implement this with the env va) will ping you when im ready, until then i've converted this to a Draft pr

KyriosGN0 avatar Jul 17 '24 18:07 KyriosGN0

@zalegrala should be good now.

KyriosGN0 avatar Oct 19 '24 16:10 KyriosGN0