helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

fix(promtail): prefer image.tag for app.kubernetes.io/version

Open yurrriq opened this issue 1 year ago • 1 comments
trafficstars

For example, when I set image.tag=2.9.8, I'd like the resulting annotation to be app.kubernetes.io/version: 2.9.8 instead of the current app.kubernets.io/version: 2.9.3 which uses the .Chart.AppVersion. I've copied from the grafana chart, which already has the correct behaviour.

yurrriq avatar Jul 01 '24 19:07 yurrriq

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 01 '24 19:07 CLAassistant

I've changed the default image.tag from null to "" which solves the linting issue, at least locally.

yurrriq avatar Jul 03 '24 16:07 yurrriq

And now I've updated README.md :facepalm: Hopefully this time the linter is finally happy.

yurrriq avatar Jul 03 '24 19:07 yurrriq