helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[grafana] conf(grafana): Add `folderUid` option

Open Rohlik opened this issue 1 year ago • 2 comments
trafficstars

My first PR 🎉 ! This simple PR should allow users to be able to set a folderUid which may help solve issues in some deployments, see referencing ticket for more info.

TICKET: Fix #2955

Rohlik avatar Feb 07 '24 14:02 Rohlik

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 07 '24 14:02 CLAassistant

@zanhsieh Thx for the review. DCO is already signed. Bumping Chart.yaml now.

Rohlik avatar Feb 09 '24 09:02 Rohlik

@zanhsieh Hey 👋🏼, can we merge this? I do not want to do a rebase again and again 🙄.

Rohlik avatar May 15 '24 07:05 Rohlik

@zanhsieh Hey 👋🏼, can we merge this? I do not want to do a rebase again and again 🙄.

@Rohlik I can't. It required two approvals. I don't control this grafana repo, grafana.com does. Long long time ago only requires single approval but they change the policy somehow. You are not alone. There are a lot of PRs in this repo having the same issue.

cc @zalegrala

zanhsieh avatar May 27 '24 00:05 zanhsieh

Just you @zanhsieh and we are ready to go 🚀.

Rohlik avatar Jun 04 '24 17:06 Rohlik

Thanks for the contribution @Rohlik.

zalegrala avatar Jun 07 '24 20:06 zalegrala