grafana-ansible-collection icon indicating copy to clipboard operation
grafana-ansible-collection copied to clipboard

fix: Ensure check-mode works for otel collector

Open pieterlexis-tomtom opened this issue 1 year ago • 4 comments

On an empty host, check-mode fails with:

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: NoneType: None
fatal: [myhost1]: FAILED! => {"changed": false, "msg": "dest '/etc/otel-collector' must be an existing dir"}

This PR does not run the breaking task in check-mode.

pieterlexis-tomtom avatar Sep 03 '24 15:09 pieterlexis-tomtom

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 03 '24 15:09 CLAassistant

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

I'm engaging our legal department. But as this is a trivial change, I am fine with someone "re-implementing" and adding it to the repository that way :).

pieterlexis-tomtom avatar Sep 03 '24 15:09 pieterlexis-tomtom

Are you fine with you making the change or do you want me to copy your changes and commit if you are not comfortable ?

ishanjainn avatar Sep 05 '24 14:09 ishanjainn

Are you fine with you making the change or do you want me to copy your changes and commit if you are not comfortable ?

CLA has been approved and I have signed it last week :)

pieterlexis-tomtom avatar Sep 09 '24 12:09 pieterlexis-tomtom