grafana-ansible-collection
grafana-ansible-collection copied to clipboard
Update Alloy variables to use the `grafana_alloy_` namespace so they are unique
This should address #206 and #194
This PR should make sure the Alloy variables are unique and won't clash with other variables (like version) used elsewhere in playbooks.
It also moves the binary and working directory out of /etc where RHEL and SELinux get upset about.
Hey @Aethylred Yeah would prefer to use alloy_ instead of grafana_alloy_
Switched to alloy_ as requested, though I suppose the code is ahead of this now.
Apologies about the delay, with the Alloy setup being immature, we switched to using the standard Grafana setup. Will be skipping Grafana Agent & Flow and waiting for Alloy.
https://github.com/grafana/grafana-ansible-collection/pull/228
BOth of the PRs seem to achive the same thing, @Aethylred Lemme know if the other PR loogs good to you aswell and we can use that or the other way around?
Looking at #228 and it looks good, I'd consider it a duplicate, but whichever crosses the line first is fine by me
Rebased on main. Not sure how to resolve the workflow errors.
Any updates on this one? Looks like the only thing missing is approval for workflows to run
Changes LGTM, Ill just test on local by tomorrow and merge release if all good
Hello ! Do you have any updates on this MR ? When will it be merge ? I don't know the process here
It looks like @ishanjainn is pending reviewer
Looking at those failed checks and I'm unsure if the problem is my MR, should I rebase again?
Dont think so it related to your changes, Chnages LGTM
Hello @ishanjainn Thanks for merging. Please review comment: 2388057978, because it broke #212!
It reverts this:
git diff 8dbd124a04d2d68689fa7fa3be91db3b077b7589 install.yml
index b78a953..d39c97b 100644
--- a/roles/alloy/tasks/install.yml
+++ b/roles/alloy/tasks/install.yml
@@ -6,37 +6,55 @@
...
- name: Create alloy user
ansible.builtin.user:
- name: "{{ service_user }}"
- groups: "{{ [ service_group ] + alloy_user_groups }}"
+ name: "{{ alloy_service_user }}"
+ group: "{{ alloy_service_group }}"
system: true
create_home: false # Appropriate for a system user, usually doesn't need a home directory
become: true
...
The {{ [ service_group ] + alloy_user_groups } was replaced to {{ alloy_service_group }} instead of {{ [ alloy_service_group ] + alloy_user_groups }}
I added MR 276.
Thanks in advance