github-datasource icon indicating copy to clipboard operation
github-datasource copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Add more user fields

Open rayfaddis opened this issue 1 year ago • 2 comments

Adds more user fields to Pull Requests:

  1. Authors name
  2. Merged by users name
  3. Merged by users login\username
  4. Merged by users email
  5. Merged by users company name

rayfaddis avatar Jan 26 '24 01:01 rayfaddis

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 26 '24 02:01 CLAassistant

Hello, can I please get a build run approved for this? @zoltanbedi maybe that's a request to you?

rayfaddis avatar Feb 05 '24 02:02 rayfaddis

Hello @ivanahuckova! and thank you for the reply. I had updated pkg/github/testdata/pull_requests.golden.jsonc and didn't see any other tests areas or test data to update. If there is an area where I could have added more tests please let me know, I am new to go.

rayfaddis avatar Aug 01 '24 15:08 rayfaddis

@rayfaddis oh yeah, you are correct. I thought we have some unit tests in pkg/github/pull_requests_test.go, but it seems that we use mainly snapshot tests. So feel free to ignore the part about the additional tests. 🙂

ivanahuckova avatar Aug 01 '24 15:08 ivanahuckova