beyla
beyla copied to clipboard
Always decorate k8s_owner_name
The non-standard k8s_owner_name attribute was used in case a given metric had an onwner of an unknown kind.
Following what already do for network metrics, k8s_owner_name will hold the name of the owner even if it is known and already reported in either the k8s_deployment_name, k8s_statefulset_name, k8s_daemonset_name or k8s_replicaset_name.
This would simplify querying and should not have impact in metrics cardinality.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.68%. Comparing base (
86c0519) to head (32900fd).
Additional details and impacted files
@@ Coverage Diff @@
## main #1226 +/- ##
==========================================
- Coverage 81.75% 81.68% -0.07%
==========================================
Files 137 137
Lines 11483 11484 +1
==========================================
- Hits 9388 9381 -7
- Misses 1558 1563 +5
- Partials 537 540 +3
| Flag | Coverage Δ | |
|---|---|---|
| integration-test | 60.37% <0.00%> (-0.39%) |
:arrow_down: |
| k8s-integration-test | 58.18% <100.00%> (-0.11%) |
:arrow_down: |
| oats-test | 36.07% <0.00%> (-0.01%) |
:arrow_down: |
| unittests | 53.03% <100.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.