alloy icon indicating copy to clipboard operation
alloy copied to clipboard

fix(helm): explicitly include namespace in manifests

Open valorl opened this issue 1 year ago • 2 comments

Currently, most of the manifests omit .metadata.namespace.

This works fine with helm install / helm upgrade where all the manifests without a namespace will be installed to --namespace anyway.

However, helm template will produce the manifests as-is (with no namespace), regardless of --namespace, forcing users to add the namespace manually or use more tooling.

This change adds the namespace to all manifests.

Fixes #1607

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • [ ] CHANGELOG.md updated
  • [ ] Documentation added
  • [ ] Tests updated
  • [ ] Config converters updated

valorl avatar Sep 04 '24 08:09 valorl

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 04 '24 08:09 CLAassistant

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

github-actions[bot] avatar Oct 05 '24 00:10 github-actions[bot]

@clayton-cornell I'm just tagging a random contributor here. What is this PR missing to get merged?

neopointer avatar Nov 08 '24 06:11 neopointer

@neopointer It looks like this one got missed in the shuffle. Lets see if we can get a developer/maintainer review happening here.

@grafana/grafana-alloy-maintainers can someone from the team take a look at this?

clayton-cornell avatar Nov 13 '24 20:11 clayton-cornell

This looks reasonable to me and the namespace defaults to release.namespace so should be backwards compatible for how it was meant to be used.

mattdurham avatar Nov 18 '24 18:11 mattdurham

@petewall any thoughts on if this causes any issue?

mattdurham avatar Nov 18 '24 18:11 mattdurham

This PR #2044 seems to be the most active and achieves the same result?

mattdurham avatar Nov 18 '24 18:11 mattdurham

Closing in favor of #2044, it's more complete and achieves the same.

valorl avatar Dec 05 '24 11:12 valorl