agent icon indicating copy to clipboard operation
agent copied to clipboard

Make EnableProtobufNegotiation configurable to enable native histogram scraping in static mode

Open Reimirno opened this issue 1 year ago • 1 comments

PR Description

Add EnableProtobufNegotiation to static config so as to enable native histogram scraping in static mode.

scrape_classic_histograms is already supported so no action here.

Which issue(s) this PR fixes

Fixes #7056

Notes to the Reviewer

PR Checklist

  • [ ] CHANGELOG.md updated
  • [ ] Documentation added
  • [ ] Tests updated
  • [ ] Config converters updated

Reimirno avatar Oct 17 '24 22:10 Reimirno

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 17 '24 22:10 CLAassistant

Can I get some eyes on this PR?

cc: @bcotton @rafaelroquetto since git blame shows your names :)

Reimirno avatar Nov 07 '24 20:11 Reimirno

Perhaps the wrong Bob?

bcotton avatar Nov 08 '24 20:11 bcotton

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

github-actions[bot] avatar Dec 09 '24 00:12 github-actions[bot]

Hi @Reimirno, apologies but I'll close the PR because we no longer add new features to static mode.

ptodev avatar Dec 18 '24 14:12 ptodev