agent icon indicating copy to clipboard operation
agent copied to clipboard

Add automemlimit

Open mattdurham opened this issue 1 year ago • 3 comments

PR Description

This sets the mem limit to 90% of requested if GOMEMLIMIT is not set and cgroup is set. This ideally should bring agent memory closer to what is requested. Tested internally and forced memory low at the expense of cpu and scaling.

PR Checklist

  • [x] CHANGELOG.md updated

mattdurham avatar Feb 26 '24 15:02 mattdurham

Can this wait until after 1.0? I'm also nervous about the impact (we don't know how it'll behave in environments of other sizes with other kinds of workloads than what we tested against ours), so I would prefer to make it experimental, but I'm not sure we should add any new experimental features this close to 1.0.

rfratto avatar Mar 05 '24 15:03 rfratto

Thats fair, I will table til then

mattdurham avatar Mar 05 '24 15:03 mattdurham

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

github-actions[bot] avatar Apr 05 '24 00:04 github-actions[bot]

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

github-actions[bot] avatar May 13 '24 00:05 github-actions[bot]

Closing; this was added to Alloy instead in grafana/alloy#655.

rfratto avatar May 13 '24 17:05 rfratto