grafana-wtf
grafana-wtf copied to clipboard
Accept `datasource` attribute on `DatasourceItem`, but ignore it
About
Dear @apepojken. This patch intends to poke at the details based on your report.
- GH-110
Details
When I try to explore datasources it always fail with a TypeError. No idea why this happens.
Exception:
TypeError: DatasourceItem.__init__() got an unexpected keyword argument 'datasource'
Thoughts
It is unlikely that this is the correct fix. It hasn't been validated in any way, so it is purely based on guessing, not even educated. We will ask a few more questions at GH-110.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.69%. Comparing base (
76e1abd) to head (c22717e).
Additional details and impacted files
@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 86.50% 86.69% +0.18%
==========================================
Files 8 8
Lines 1060 1067 +7
==========================================
+ Hits 917 925 +8
+ Misses 143 142 -1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 86.69% <100.00%> (+0.18%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We verified the status on play.grafana.org, without the patch, and there haven't been any issues.
- https://github.com/panodata/grafana-wtf/issues/110#issuecomment-2028491583
Therefore, we are hibernating this patch back into draft mode.