playframework icon indicating copy to clipboard operation
playframework copied to clipboard

Published 20 hours ago • verified publisher icon gradle

Fix archive baseName

Open PaulFridrick opened this issue 5 years ago • 4 comments

I found an odd condition in PlayDistributionPlugin:143 when browsing the plugin source code. I think I fixed the generated archives (zip & tar) base name.

I had to change some tests but it seems legitimate in this case.

PaulFridrick avatar Dec 06 '19 16:12 PaulFridrick

Updated to resolve the conflicts with master

PaulFridrick avatar Oct 15 '20 14:10 PaulFridrick

Hey @PaulFridrick this would technically be an API breaking change. If we're going to make this change, it will need to be documented in the release notes.

JLLeitschuh avatar Nov 19 '20 15:11 JLLeitschuh

Hello ! Yes it makes sense, should I add a line in the changelog AsciiDoc file on this branch then ? I see the generated start scripts are also named 'main', whereas with the Application Gradle plugin the project name is used by convention. Maybe I should also fix it on this branch to group the breaking changes ?

PaulFridrick avatar Nov 22 '20 14:11 PaulFridrick

Hi, the fix seems to be trivial and is already 3 years old. Is it possible to move this forward ?

IvanGeorgiev89 avatar Oct 23 '23 19:10 IvanGeorgiev89