gradle-enterprise-build-validation-scripts icon indicating copy to clipboard operation
gradle-enterprise-build-validation-scripts copied to clipboard

Move build summary extraction logic out

Open sorin-florea opened this issue 2 years ago • 1 comments

sorin-florea avatar Aug 22 '23 10:08 sorin-florea

Successfully ran the below experiments at commit 0e2028a470faa775e65c499f5a5252b70db5e33d.

./01-validate-incremental-building.sh -r [email protected]:gradle/gradle-build-scan-quickstart.git -c 710a21dad423192a0ea2d9aea77f381f40eb8a6a -t 'build' -s https://ge.solutions-team.gradle.com
./02-validate-local-build-caching-same-location.sh -r [email protected]:gradle/gradle-build-scan-quickstart.git -c 710a21dad423192a0ea2d9aea77f381f40eb8a6a -t 'build' -s https://ge.solutions-team.gradle.com
./03-validate-local-build-caching-different-locations.sh -r [email protected]:gradle/gradle-build-scan-quickstart.git -c 710a21dad423192a0ea2d9aea77f381f40eb8a6a -t 'build' -s https://ge.solutions-team.gradle.com

./01-validate-local-build-caching-same-location.sh -r [email protected]:gradle/maven-build-scan-quickstart.git -c feb731de5b279d3a941f81fb3d1845ec0405388b -g 'verify' -s https://ge.solutions-team.gradle.com
./02-validate-local-build-caching-different-locations.sh -r [email protected]:gradle/maven-build-scan-quickstart.git -c feb731de5b279d3a941f81fb3d1845ec0405388b -g 'verify' -s https://ge.solutions-team.gradle.com

erichaagdev avatar May 03 '24 14:05 erichaagdev

When I invoke a script I get this right at the start:

image

Message:

/Users/eric/Projects/gradle/gradle-enterprise-gradle-build-validation/local/lib/scripts/exit-code.sh: line 3: SUCCESS: readonly variable

To reproduce it, just run:

./01-validate-incremental-building.sh \
  -r [email protected]:gradle/gradle-build-scan-quickstart.git \
  -c 710a21dad423192a0ea2d9aea77f381f40eb8a6a \
  -t 'build' \
  -s https://ge.solutions-team.gradle.com

erichaagdev avatar May 09 '24 19:05 erichaagdev

This is probably an issue with the jar, but I noticed this in debug mode:

image

erichaagdev avatar May 09 '24 19:05 erichaagdev

When I invoke a script I get this right at the start:

image

Message:

/Users/eric/Projects/gradle/gradle-enterprise-gradle-build-validation/local/lib/scripts/exit-code.sh: line 3: SUCCESS: readonly variable

To reproduce it, just run:

./01-validate-incremental-building.sh \
  -r [email protected]:gradle/gradle-build-scan-quickstart.git \
  -c 710a21dad423192a0ea2d9aea77f381f40eb8a6a \
  -t 'build' \
  -s https://ge.solutions-team.gradle.com

Fixed in https://github.com/gradle/gradle-enterprise-build-validation-scripts/pull/487/commits/9fadce5a882f99c72a146166e1dffa0f96a3076d

jthurne avatar May 09 '24 20:05 jthurne

Did some testing and all looks good up to this point. Each distribution has their respective license and scripts are working as expected.

erichaagdev avatar May 23 '24 21:05 erichaagdev