Niklas Bichinger

Thank you for the great feedback!! @codegeek319 has been implementing this and we'll discuss it on Tuesday, we work together irl. :)

Sure thing! Sorry, we have been quite busy ☺️

@igorkasyanchuk finally I found the time for the refactoring you suggested. Diff shrunk significantly. Would you mind taking another look? :)

@StefSchenkelaars I commented on and coded towards your suggestions. :) What do you think?

> I still don't really like the passing of these options all the time but I'm ok if it works. I'm totally open to suggestions! Please check the validators and...

I think this PR could be merged now.

Nice feature! A short test for the change of the base class would be great imho.

That's a little strange imho: if you save the attachment before the comfy File model, the attachment shouldn't be able to attach itself to anything (as the File model doesn't...

In fact, Rails 6's behaviour is better imho, but your PR also changed how the attachment save code behaves on 5.2... What do you think about conditionally adapting the hook...

@dinatih ActionText/trix seems quite limited though, especially when comparing it to Redactor... The official plugins seem extremely broad and valuable without bloating the editor. @GBH I just re-stumbled upon CMS...