gpt-engineer icon indicating copy to clipboard operation
gpt-engineer copied to clipboard

reproducibility, patterns, pythonisms

Open JacobFV opened this issue 2 years ago • 8 comments

Thank thank you thank you Anton. You won. My dream of building ComputaCode is probabbly over. lol. It's okay. I'm happy for everyone else.

For reproducibility purposes, I recommend using poetry since it records package versions. Also it simplifies building wheels and publishing.

I've updated the configured for poetry, reorganized some files to follow the pythonic conventions, and updated referenced. Please see my fork.

JacobFV avatar Jun 11 '23 01:06 JacobFV

Had to make some more changes to get poetry to work from the CLI. But now you should have entry points that pipx recognizes.

JacobFV avatar Jun 11 '23 02:06 JacobFV

Ready to merge

JacobFV avatar Jun 11 '23 02:06 JacobFV

Thanks so much for the PR!

There are some conflicts now, and I can't fix them before merge.

If you do it I'd be happy to merge.

Also: do you want to delete pycache files and my-new-project directory? ❤️

AntonOsika avatar Jun 11 '23 16:06 AntonOsika

Thanks so much for the PR!

There are some conflicts now, and I can't fix them before merge.

If you do it I'd be happy to merge.

Also: do you want to delete pycache files and my-new-project directory? ❤️

Thanks. I see.

Away from home rn but will commit in about an hour

Yes

JacobFV avatar Jun 11 '23 17:06 JacobFV

I think this is ready to merge, but Github won't let me. I'm able to finish with my permissions tho:

Screenshot from 2023-06-11 15-30-03 Screenshot from 2023-06-11 15-29-23

JacobFV avatar Jun 11 '23 20:06 JacobFV

Thanks @JacobFV!

To resolve the conflicts you need to do a pull on the main branch of the repo.

I.e. something like:

git remote add upstream https://github.com/AntonOsika/gpt-engineer

git pull upstream

And then resolve conflicts (I use pycharm to resolve but up to you ofc)

AntonOsika avatar Jun 12 '23 06:06 AntonOsika

Closing, more context in #38

Thanks @JacobFV

patillacode avatar Jun 15 '23 20:06 patillacode

Hi, been busy. Thank you

JacobFV avatar Jun 15 '23 20:06 JacobFV