websocket icon indicating copy to clipboard operation
websocket copied to clipboard

Published 20 hours ago • verified publisher icon gorilla

Handle errcheck warnings

Open canelohill opened this issue 1 year ago • 1 comments

What type of PR is this? (check all applicable)

  • [ ] Refactor
  • [ ] Feature
  • [x] Bug Fix
  • [ ] Optimization
  • [ ] Documentation Update
  • [ ] Go Version Update
  • [ ] Dependency Update

Description

The package ignored errors from net.Conn Set*Deadline in a few places. Update the package to return these errors to the caller.

Ignore all other errors reported by errcheck. These errors are safe to ignore because

  • The function is making a best effort to cleanup while handling another error.
  • The function call is guaranteed to succeed.
  • The error is ignored in a test.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Added/updated tests?

  • [ ] Yes
  • [x] No, and this is why: covered by existing tests
  • [ ] I need help with writing tests

Run verifications and test

  • [ ] make verify is passing
  • [ ] make test is passing

canelohill avatar Jun 18 '24 22:06 canelohill

@canelohill I had to manually resolve a conflict. Can you check and make sure that fits what you think should happen?

jaitaiwan avatar Jul 01 '24 03:07 jaitaiwan

The PR looks good after merges.

ghost avatar Jul 02 '24 20:07 ghost

@canelohill can’t seem to merge it says there’s conflicts

jaitaiwan avatar Jul 02 '24 23:07 jaitaiwan

The PR should merge clean now.

ghost avatar Jul 05 '24 17:07 ghost

Cheers thanks for that. I was surprised cause usually I get the opportunity to resolve conflicts manually but this time there was no option.

jaitaiwan avatar Jul 06 '24 00:07 jaitaiwan

hi🫡

shahshahii avatar Feb 04 '25 03:02 shahshahii