mux icon indicating copy to clipboard operation
mux copied to clipboard

Added a fuzzer

Open AdamKorcz opened this issue 5 years ago • 8 comments
trafficstars

This PR adds a fuzzer for the Regexp functionality. It does not modify any core functionality.

The fuzzer can be run locally, and I will be happy to setup continuous fuzzing as well through oss-fuzz. This would allow Google to run the fuzzer periodically and notify maintainers in case any bugs were found.

A small note on this fuzzer: It panics here, and the optimal solution to that would be to remove the panic from a point of view of fuzzing. However, since there is just a single panic in regexp.go, we could remove it during fuzzing runs or rewrite it slightly to not stop the fuzzer. This would be the solution in the case on running continuous fuzzing.

Signed-off-by: AdamKorcz [email protected]

AdamKorcz avatar Jun 04 '20 18:06 AdamKorcz

This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.

stale[bot] avatar Aug 19 '20 07:08 stale[bot]

I will be happy to setup continuous fuzzing as well through oss-fuzz

@AdamKorcz are you still working on this?

amustaque97 avatar Jun 09 '22 19:06 amustaque97

I will be happy to setup continuous fuzzing as well through oss-fuzz

@AdamKorcz are you still working on this?

I will still be happy to see this integrated.

AdamKorcz avatar Jun 09 '22 19:06 AdamKorcz

I will be happy to setup continuous fuzzing as well through oss-fuzz

@AdamKorcz are you still working on this?

I will still be happy to see this integrated.

I was going through the article https://adalogics.com/blog/fuzzing-istio-cve-CVE-2022-23635 and I strongly believe we should integrate with mux project as well.

cc @elithrar would love to hear your thoughts as well.

amustaque97 avatar Jun 09 '22 19:06 amustaque97

I will be happy to setup continuous fuzzing as well through oss-fuzz

@AdamKorcz are you still working on this?

I will still be happy to see this integrated.

I was going through the article https://adalogics.com/blog/fuzzing-istio-cve-CVE-2022-23635 and I strongly believe we should integrate with mux project as well.

cc @elithrar would love to hear your thoughts as well.

Thank you for reading our blog post. I also believe Gorilla Mux will benefit from this.

AdamKorcz avatar Jun 09 '22 20:06 AdamKorcz

This seems fine, although the scope of the fuzzing seems constrained to the route matching regexp.

elithrar avatar Jun 13 '22 11:06 elithrar

This seems fine, although the scope of the fuzzing seems constrained to the route matching regexp.

You are correct. We can add more fuzzers anytime. This first fuzzer is a starter to get continuous fuzzing of Mux set up.

AdamKorcz avatar Jun 13 '22 11:06 AdamKorcz

Hey @AdamKorcz :wave: - just a quick follow-up - are you still working on it?

amustaque97 avatar Jun 24 '22 07:06 amustaque97

@coreydaley Why was this closed?

AdamKorcz avatar Aug 16 '23 08:08 AdamKorcz

I'm not sure that it is something that we are interested in implementing at this time. Can you give a more detailed explanation of how introducing fuzzing for this particular function would benefit the project?

coreydaley avatar Aug 16 '23 15:08 coreydaley