ferium icon indicating copy to clipboard operation
ferium copied to clipboard

Pick which mod to download if multiple hits were found

Open JustSimplyKyle opened this issue 3 years ago • 8 comments

If I'm being more specific, when option --dont-check-game-version or --dont-check-mod-loader is provided, prompt the user to choose which one should be downloaded. The main usage for this would be github mods, since a lot of them has 1.18 in the title but not 1.18.2, but if I provide --dont-check-game-version, it will often download the incorrect version. Notable example: https://github.com/SpaceWalkerRS/alternate-current/releases/tag/v1.2

JustSimplyKyle avatar May 26 '22 02:05 JustSimplyKyle

My goodness, what kind of atrocity is that release? It's a complete mess! They should learn how to properly release software.

Damn, now I'm thinking I should have never got into the trouble of implementing GitHub Releases because there will inevitably be people using them completely incorrectly.

theRookieCoder avatar May 26 '22 09:05 theRookieCoder

~~https://github.com/gorilla-devs/gdlauncher/releases/latest~~

Eskaan avatar May 26 '22 09:05 Eskaan

~https://github.com/gorilla-devs/gdlauncher/releases/latest~

wtf? Is there anything explaining what the files even are?

theRookieCoder avatar May 26 '22 09:05 theRookieCoder

That's just nearly everything that gets outputted by nom run release

Eskaan avatar May 26 '22 09:05 Eskaan

My goodness, what kind of atrocity is that release? It's a complete mess! They should learn how to properly release software.

Well a more "normal" example is VulkanMod! https://github.com/xCollateral/VulkanMod/releases/tag/0.1.4%2B3 it's 1.18 so it doesn't work with 1.18.2, but if i ignore the check, it will download the 1.17 verison instead

JustSimplyKyle avatar May 26 '22 12:05 JustSimplyKyle

Actually, this can be fixed by #29 right? Why would we need a filter and a picker?

theRookieCoder avatar May 26 '22 15:05 theRookieCoder

Sometimes regex filtering is difficult for newcomers to implement But a file picker doesn't need any other user configuration

JustSimplyKyle avatar May 26 '22 23:05 JustSimplyKyle

Sometimes regex filtering is difficult for newcomers to implement

I wasn't thinking of a regex, more of a glob pattern. Sort of like gh release download's glob pattern downloads. But yeah ig both would be ideal.

theRookieCoder avatar May 27 '22 06:05 theRookieCoder