ferium icon indicating copy to clipboard operation
ferium copied to clipboard

Add ability to upgrade the mods of all profiles

Open logistic-bot opened this issue 2 years ago • 4 comments

Closes #270

Also added an indicator to show which profile is currently being worked on. This is currently shown even if only one profile is being update

logistic-bot avatar Feb 14 '23 20:02 logistic-bot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 14 '23 20:02 CLAassistant

This is my first contribution to open source, I hope I did everything correctly.

logistic-bot avatar Feb 14 '23 20:02 logistic-bot

While testing this I noticed that it tries to upgrade all profiles, even if there are in the same mod folder, which doesn’t make sense because the freshly upgraded files are removed instantly when upgrading the next profile. There needs to be a check so that only profiles that are in another mod directory are upgraded too. That’s the next problem though: We have no way of knowing which profile is supposed to be active in other directories. (#322)

@theRookieCoder planned to add this with #163, so I don’t think it is necessary to update this.

tippfehlr avatar May 16 '23 18:05 tippfehlr

While testing this I noticed that it tries to upgrade all profiles, even if there are in the same mod folder, which doesn’t make sense because the freshly upgraded files are removed instantly when upgrading the next profile

Hmm yes valid point.

There needs to be a check so that only profiles that are in another mod directory are upgraded too

I will consider this when implementing the feature. My plan is to warn or not allow the user to add profiles that output to the same directory, and suggest that they use multiple launcher profiles as intended.

theRookieCoder avatar May 17 '23 11:05 theRookieCoder