ferium icon indicating copy to clipboard operation
ferium copied to clipboard

Add scanning functionality

Open tuxinal opened this issue 3 years ago • 7 comments

same as #170 but squashed to avoid the mess

tuxinal avatar Sep 12 '22 07:09 tuxinal

What does this do? Scan a folder for importing existing mods into ferium?

tippfehlr avatar Mar 14 '23 18:03 tippfehlr

it's a bit weird since it doesn't seem to build properly

LunarN0v4 avatar May 10 '23 10:05 LunarN0v4

it's a bit weird since it doesn't seem to build properly

I can confirm that this isn’t building:

error[E0432]: unresolved imports `libium::config::structs::ModPlatform`, `libium::scan`
  --> src/subcommands/scan.rs:9:43
   |
9  |     config::structs::{Mod, ModIdentifier, ModPlatform, Profile},
   |                                           ^^^^^^^^^^^ no `ModPlatform` in `config::structs`
10 |     scan,
   |     ^^^^ no `scan` in the root
   |
   = help: consider importing this module instead:
           crate::subcommands::scan

error[E0433]: failed to resolve: could not find `ModPlatform` in `structs`
   --> src/main.rs:357:71
    |
357 |                 preferred_platform.unwrap_or(libium::config::structs::ModPlatform::Modrinth),
    |                                                                       ^^^^^^^^^^^ could not find `ModPlatform` in `structs`

error[E0412]: cannot find type `ModPlatform` in module `libium::config::structs`
  --> src/cli.rs:90:61
   |
90 |         preferred_platform: Option<libium::config::structs::ModPlatform>
   |                                                             ^^^^^^^^^^^ not found in `libium::config::structs`

error[E0412]: cannot find type `ModPlatform` in module `libium::config::structs`
  --> src/subcommands/scan.rs:18:50
   |
18 |     preferred_platform: libium::config::structs::ModPlatform,
   |                                                  ^^^^^^^^^^^ not found in `libium::config::structs`

error[E0609]: no field `project_id` on type `&_`
  --> src/subcommands/scan.rs:51:69
   |
51 |                         ModIdentifier::ModrinthProject(modrinth_mod.project_id.clone())
   |                                                                     ^^^^^^^^^^

error[E0609]: no field `mod_id` on type `&_`
  --> src/subcommands/scan.rs:54:73
   |
54 |                         ModIdentifier::CurseForgeProject(curseforge_mod.mod_id)
   |                                                                         ^^^^^^

Some errors have detailed explanations: E0412, E0432, E0433, E0609.
For more information about an error, try `rustc --explain E0412`.
error: could not compile `ferium` due to 6 previous errors

tippfehlr avatar May 16 '23 18:05 tippfehlr

you have to change the libium dependency in Cargo.toml to the squash branch of my fork for it to build

What does this do? Scan a folder for importing existing mods into ferium?

Yes exactly that see #57

tuxinal avatar May 17 '23 05:05 tuxinal

why haven't you done that? and your branch is many commits behind

LunarN0v4 avatar May 17 '23 10:05 LunarN0v4

why haven't you done that?

Tuxinal is probably waiting for upstream changes that allow multiple mods to be properly added.

Also please change your tone, slow progress is typical of open source projects, and in the majority of cases it is up to the authors to spare their free time for the project. I'd be more than happy if you'd like to help us out, we have tons of requested features in the backlog. They are all publicly tracked in GitHub Issues so that anyone can contribute, even with non-programming related tasks like auditing theoretical enhancements or planning out large structural changes.

theRookieCoder avatar May 17 '23 11:05 theRookieCoder

Also please change your tone

sorry, I was annoyed at the time because of personal issues

LunarN0v4 avatar May 20 '23 01:05 LunarN0v4

Superseded by 9929937b0594f9f562e77631b436a2268742f598

theRookieCoder avatar Jun 11 '24 13:06 theRookieCoder