tensor icon indicating copy to clipboard operation
tensor copied to clipboard

Upgrade assume-no-moving-gc to the latest version.

Open wipsel opened this issue 3 years ago • 4 comments

Hi

We have been using this package in some of our projects. It has been working great so far. Since go 1.18 we have a panic caused by assume-no-moving-gc. This can be fixed by setting the env var : ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.18

I updated the version in go.mod and it looks like everything is working. I don't know if this has any other implications. But Would be nice to get rid of the panic and update the package to go 1.18?

I'll try to create a pull request with the changes.

wipsel avatar Jun 27 '22 07:06 wipsel

Hi again

Since the last version 3 new go versions have been released. I was wondering why go4.org/unsafe/assume-no-moving-gc is imported and if we could get rid of it in the future so that we won't need update it every time the go runtime is updated.

wipsel avatar May 17 '23 10:05 wipsel

Arghhhhh! I thought I updated this. I even tweeted about updating this!! I need to go find the machine where I made the change, as I suspect I didn't make a push.

chewxy avatar May 17 '23 10:05 chewxy

I just ran into this problem. Any chance for a fix?

pdevine avatar Jan 30 '24 21:01 pdevine

I ended up just forking the repo into pdevine/tensor and patching that to not through the error. I'll kill that fork if this ever gets updated.

pdevine avatar Mar 15 '24 00:03 pdevine