apps-script-samples icon indicating copy to clipboard operation
apps-script-samples copied to clipboard

feat(calendar): Readded multiple groups and added blocked groups

Open lwcorp opened this issue 1 year ago • 1 comments

Description

  1. Undid the removal of the support for multiple groups (why did you allow this person's PR just so they fix formatting?)
  2. Made the multiple groups and get all members functions to use each other to avoid duplicated code
  3. Added support for avoiding blocked groups (e.g. external ones)
  4. Fixed to prevent script crash when any event has no summary
  5. Simplified both functions' code
  6. Fixed spelling while at it (hope it's okay to avoid an extra PR just to put fix in the title instead of feat)

Is it been tested?

  • [X] Development testing done

Checklist

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have performed a peer-reviewed with team member(s)
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] My changes generate no new warnings
  • [X] Any dependent changes have been merged and published in downstream modules

lwcorp avatar Apr 15 '24 19:04 lwcorp

Please note the failed tests failed Google's own original code, not my additions.

lwcorp avatar Apr 15 '24 19:04 lwcorp