unity-jar-resolver icon indicating copy to clipboard operation
unity-jar-resolver copied to clipboard

Avoid calling UpdateVersionedAssetsOnUpdate with each Play in Editor.

Open bhallionOhbibi opened this issue 2 years ago • 1 comments

Avoid unecessary computation of manifest each time the play mode is started in editor. This computation takes multiple seconds each time we press play on many projects. This computation is already made with each asset refresh.

Please note that this was already made on the firebase-unity-sdk equivalent few years ago: GenerateXmlFromGoogleServicesJson https://github.com/firebase/firebase-unity-sdk/blob/778a4841ac67616b2bd88a6e6f740a816d75b13b/editor/app/src/GenerateXmlFromGoogleServicesJson.cs#L96

bhallionOhbibi avatar Dec 28 '22 11:12 bhallionOhbibi

Please please please accept this pull request. It is completely unacceptable that the resolver makes iterating projects slower.

Tommigun1980 avatar Apr 05 '23 12:04 Tommigun1980