unity-jar-resolver
unity-jar-resolver copied to clipboard
+ Add support to "podspec" parameter for #452
Add support to "podspec" parameter. If both "podspec" and "path" is present, it will prefer "podspec" over "path" for that specific pod.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@chkuang-g Hi, I have updated the changes:
- Rename "podspec" to "podspecPath" to avoid conflicts if any
- Support http for "podspecPath"
I have built the plugin and tested. It is working fine locally with this format in Dependencies.xml:
<iosPods>
<iosPod name="IronSourceFyberAdapter" podspecPath="Assets/Plugins/ThirdParties/IronSource/Editor/LocalPod/IronSourceFyberAdapter.podspec.json">
</iosPod>
</iosPods>
Still I haven't managed to compile the source into a .tgz for use in Unity Package Manager. I will try again later.
Please let me know if you need any other changes then.
Thanks Phong
@camphongdinh
Thanks for the update. I will take a look today.