unity-jar-resolver icon indicating copy to clipboard operation
unity-jar-resolver copied to clipboard

+ Add support to "podspec" parameter for #452

Open camphongdinh opened this issue 4 years ago • 4 comments

Add support to "podspec" parameter. If both "podspec" and "path" is present, it will prefer "podspec" over "path" for that specific pod.

camphongdinh avatar Jul 14 '21 09:07 camphongdinh

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 14 '21 09:07 google-cla[bot]

@googlebot I signed it!

camphongdinh avatar Jul 14 '21 09:07 camphongdinh

@chkuang-g Hi, I have updated the changes:

  • Rename "podspec" to "podspecPath" to avoid conflicts if any
  • Support http for "podspecPath"

I have built the plugin and tested. It is working fine locally with this format in Dependencies.xml:

<iosPods>
    <iosPod name="IronSourceFyberAdapter" podspecPath="Assets/Plugins/ThirdParties/IronSource/Editor/LocalPod/IronSourceFyberAdapter.podspec.json">
    </iosPod>
  </iosPods>

Still I haven't managed to compile the source into a .tgz for use in Unity Package Manager. I will try again later.

Please let me know if you need any other changes then.

Thanks Phong

camphongdinh avatar Jul 30 '21 15:07 camphongdinh

@camphongdinh

Thanks for the update. I will take a look today.

chkuang-g avatar Aug 06 '21 20:08 chkuang-g