unity-jar-resolver
unity-jar-resolver copied to clipboard
Fixed invalid repo path patching & added user setting for path resolution
This fixes #426 where paths would be combined incorrectly on Windows (used backslash when forward slash is expected).
As discussed in the comments, I also added a user setting "Use relative repository path":

The value defaults to false to preserve existing behavior.
Sorry for the late reply and thanks for the PR!
Unfortunately I have not been able to run the existing integration tests locally, so I've opted to add a TODO. The gradle process simply gets stuck at 85% (:testAndroidResolverIntegrationTestsBatchMode).
As a sidenote, I have also had multiple issues with setting up the build environment, which took a while to figure out:
- Project only works with Unity 5.6.7f1.
- The build script failed on multiple steps:
- Path to editor only works with default paths
- Python bootstrapping (ended up commenting it out locally & just using my system install) I've attached the output here: PythonBootstrapStacktrace.txt
- Mono path refers to a
.batfile, but file is an.exein my clean editor installation. - Solutions refer to
source/unity_dllsandunity_dlls- had to symlink them to inside the editor folder (5.6.7f1\Editor\Data\Managed)
Thanks for the contribution!
I think this also fixed #239 as well
Unfortunately I have not been able to run the existing integration tests locally, so I've opted to add a TODO. The gradle process simply gets stuck at 85% (
:testAndroidResolverIntegrationTestsBatchMode).As a sidenote, I have also had multiple issues with setting up the build environment, which took a while to figure out:
Project only works with Unity 5.6.7f1.
The build script failed on multiple steps:
- Path to editor only works with default paths
- Python bootstrapping (ended up commenting it out locally & just using my system install) I've attached the output here: PythonBootstrapStacktrace.txt
- Mono path refers to a
.batfile, but file is an.exein my clean editor installation.- Solutions refer to
source/unity_dllsandunity_dlls- had to symlink them to inside the editor folder (5.6.7f1\Editor\Data\Managed)
There are a couple of issue to build EDM4U from Windows now. You can see more information on #448
If you cannot build EDM4U, have you ever checked if your change works for your case?
If not, I will need to take some time to test your change locally later.
There are a couple of issue to build EDM4U from Windows now. You can see more information on #448
Those are indeed the same issues I've experienced 👍
If you cannot build EDM4U, have you ever checked if your change works for your case?
I did get it to build by making the mentioned changes, and have verified the behavior for my case locally.
Hi @strawlink
Thank you for the contribution! This should be patched in #604. I will close this PR for now