unity-jar-resolver icon indicating copy to clipboard operation
unity-jar-resolver copied to clipboard

Resolver downloads incompatible API 28 libraries

Open kevinfoley opened this issue 7 years ago • 1 comments

If we call this:

Google.VersionHandler.InvokeInstanceMethod(svcSupport, "DependOn", 
    new object[] 
    { "com.android.support", "support-v4", "LATEST" }, namedArgs: new Dictionary<string, object>()
        { { "packageIds", new string[] { "extra-android-m2repository" } }
 });

then Play Services Resolver downloads support libraries for API 28. Unity is not currently compatible with API level 28 and this causes build errors

No resource identifier found for attribute "appComponentFactory"

kevinfoley avatar Oct 11 '18 23:10 kevinfoley

@kevinfoley the resolver just downloads what you ask it to download. There are guarantees made around it working in your project, it only currently tries to make sure that if conflicts are found between the dependencies you've specified, they are resolved.

I guess you could argue that it should have special cases for libraries like the Android support library which is almost a system library. i.e if we had a rule that messed with the selected support library versions to follow https://developer.android.com/topic/libraries/support-library/#release-versions it may not be the worst idea in the world. If you want to send a pull request, I can take a look.

That said, the most burning issue is compatibility with androidx and the old support libraries which is totally unsupported at the moment.

stewartmiles avatar Oct 11 '18 23:10 stewartmiles