google-signin-unity icon indicating copy to clipboard operation
google-signin-unity copied to clipboard

[New Release HERE!!!] Update native sdk version to 6.0.2 & REFECTOR iOS Adapter

Open CodeMasterYi opened this issue 3 years ago • 70 comments

Update native sdk version to latest & refactor iOS adapter!

before google's future new release(greater than 1.0.4 released in 2018), you guys can try import this. [email protected] It depends on EDM4U(aka. unity-jar-resolver).

https://github.com/CodeMasterYi/google-signin-unity/releases

CodeMasterYi avatar Dec 16 '21 03:12 CodeMasterYi

Tested on iOS and works great! Many thanks

Would you fire a new release?

CodeMasterYi avatar Oct 27 '22 07:10 CodeMasterYi

I don't work for Google, can I do that?

On Thu, Oct 27, 2022 at 12:29 AM Spermoverflow @.***> wrote:

Tested on iOS and works great! Many thanks

Would you fire a new release?

— Reply to this email directly, view it on GitHub https://github.com/googlesamples/google-signin-unity/pull/205#issuecomment-1293108303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALIT6YXYJDKFRSKV6DKDP3WFIVMPANCNFSM5KFHXUMA . You are receiving this because you commented.Message ID: @.***>

-- Roger Miller | Collective Mass | 424 603 7827

collectivemass avatar Oct 27 '22 10:10 collectivemass

I don't work for Google, can I do that? On Thu, Oct 27, 2022 at 12:29 AM Spermoverflow @.> wrote: Tested on iOS and works great! Many thanks Would you fire a new release? — Reply to this email directly, view it on GitHub <#205 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALIT6YXYJDKFRSKV6DKDP3WFIVMPANCNFSM5KFHXUMA . You are receiving this because you commented.Message ID: @.> -- Roger Miller | Collective Mass | 424 603 7827

Aha. I mistakenly thought you work for Google~

CodeMasterYi avatar Oct 28 '22 02:10 CodeMasterYi

This could help me and my guys but I have a hard time to build this, I am not much in Java anymore since C# exists, can anyone tell me what to do to build this? I tried on Windows WSL 2 and got the below error.

winux@MSIGF63:~/gis/google-signin-unity$ ./build_all.sh --scan
~/gis/google-signin-unity ~/gis/google-signin-unity

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine java version from '11.0.17'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org
~/gis/google-signin-unity
winux@MSIGF63:~/gis/google-signin-unity$ sudo update-alternatives --config java
There is only one alternative in link group java (providing /usr/bin/java): /usr/lib/jvm/java-11-openjdk-amd64/bin/java
Nothing to configure.
winux@MSIGF63:~/gis/google-signin-unity$

thanks for any help

Edit1: After following this guide https://www.javaprogramto.com/2021/11/could-not-determine-java-version.html I stuck now with

winux@MSIGF63:~/gis/google-signin-unity$ ./build_all.sh --scan
~/gis/google-signin-unity ~/gis/google-signin-unity

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':native-googlesignin'.
> SDK location not found. Define location with sdk.dir in the local.properties file or with an ANDROID_HOME environment variable.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s
~/gis/google-signin-unity
winux@MSIGF63:~/gis/google-signin-unity$

gradle version is at 5.4.1

About that sdk issues there is an addon to the readme in this fork https://github.com/wakawa2003/google-signin-unity-fixed It would be really great if someone could build this and put it somewhere to download for everyone

karstenkx avatar Dec 14 '22 00:12 karstenkx

This could help me and my guys but I have a hard time to build this, I am not much in Java anymore since C# exists, can anyone tell me what to do to build this? I tried on Windows WSL 2 and got the below error.

winux@MSIGF63:~/gis/google-signin-unity$ ./build_all.sh --scan
~/gis/google-signin-unity ~/gis/google-signin-unity

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine java version from '11.0.17'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org
~/gis/google-signin-unity
winux@MSIGF63:~/gis/google-signin-unity$ sudo update-alternatives --config java
There is only one alternative in link group java (providing /usr/bin/java): /usr/lib/jvm/java-11-openjdk-amd64/bin/java
Nothing to configure.
winux@MSIGF63:~/gis/google-signin-unity$

thanks for any help

Edit1: After following this guide https://www.javaprogramto.com/2021/11/could-not-determine-java-version.html I stuck now with

winux@MSIGF63:~/gis/google-signin-unity$ ./build_all.sh --scan
~/gis/google-signin-unity ~/gis/google-signin-unity

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':native-googlesignin'.
> SDK location not found. Define location with sdk.dir in the local.properties file or with an ANDROID_HOME environment variable.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s
~/gis/google-signin-unity
winux@MSIGF63:~/gis/google-signin-unity$

gradle version is at 5.4.1

About that sdk issues there is an addon to the readme in this fork https://github.com/wakawa2003/google-signin-unity-fixed It would be really great if someone could build this and put it somewhere to download for everyone

So sorry for the inconvenience. But you should not build it yourself and you can do following this:

  1. import package @ here first https://github.com/googlesamples/google-signin-unity/releases/tag/v1.0.4
  2. modify the files that included in this PR

If it works, it would be nice to let me know. @karstenkx

CodeMasterYi avatar Dec 16 '22 08:12 CodeMasterYi

If it works, it would be nice to let me know. @karstenkx

Yes, in the end It worked when I installed that stone old "latest" release and then use the files in your PR , put them into the project overwritting , we both know a proper build and package release would be better

karstenkx avatar Dec 17 '22 12:12 karstenkx

If it works, it would be nice to let me know. @karstenkx

Yes, in the end It worked when I installed that stone old "latest" release and then use the files in your PR , put them into the project overwritting , we both know a proper build and package release would be better

@karstenkx I'm sorry for that. I havent tried to rebuild a new package release. I dont work for google. I just provide a patch fix for some else to work around the not up to date issue. If you have time to do so, that would be wonderful. Nice day!

CodeMasterYi avatar Dec 19 '22 06:12 CodeMasterYi

Guy i need a help i am getting this error 'GoogleSignIn/GIDAuthentication.h' file not found Screenshot 2022-12-19 at 6 08 44 PM

MrKhan2022 avatar Dec 19 '22 13:12 MrKhan2022

Guy i need a help i am getting this error 'GoogleSignIn/GIDAuthentication.h' file not found Screenshot 2022-12-19 at 6 08 44 PM

image

MrKhan2022 avatar Dec 19 '22 13:12 MrKhan2022

Having the same issue as @MrKhan2022. I'm pretty sure it was working a few days ago. Any help would be appreciated.

Edit: If anyone still struggling with this, changing the dependency version from >=6.0.2 to =6.2.4 solved it for me.

Crazak avatar Dec 19 '22 20:12 Crazak

Having the same issue as @MrKhan2022. I'm pretty sure it was working a few days ago. Any help would be appreciated.

Edit: If anyone still struggling with this, changing the dependency version from >=6.0.2 to =6.2.4 solved it for me.

@Crazak Glad to hear that you have work around the issue.

Edit: May I have your unity version and xcode version(with macos version)?

CodeMasterYi avatar Dec 22 '22 08:12 CodeMasterYi

Unity Version: 2021.3.8f1 Xcode version: 13.2.1 MacOs: macOS Big Sur version 11.7.1 @CodeMasterYi

MrKhan2022 avatar Dec 23 '22 10:12 MrKhan2022

Guys please help me, still getting error like @MrKhan2022 described

Amrazyan avatar Jan 01 '23 08:01 Amrazyan

Screen Shot 2023-01-01 at 12 41 24

.

Amrazyan avatar Jan 01 '23 08:01 Amrazyan

Guys please help me, still getting error like @MrKhan2022 described

I cant find clientID, uiDelegate and delegate in my implementation.

CodeMasterYi avatar Jan 04 '23 06:01 CodeMasterYi

[email protected] @Amrazyan unzip this file and try import this unity package that modified by me.

CodeMasterYi avatar Jan 04 '23 06:01 CodeMasterYi

Hi, I'm trying to build this, but I'm having a similar error to MrKhan, but in my case is another file (GIDSignIn), I've tried creating a new project and importing everything cited on this thread, but it still happens, even switch from 6.0.2 to 6.2.4. I'm testing using the latest xcode with macOS Ventura, with an apple M1. I'm not using Firebase, just the GoogleSignIn.

image

matbn avatar Jan 10 '23 20:01 matbn

Hi, I'm trying to build this, but I'm having a similar error to MrKhan, but in my case is another file (GIDSignIn), I've tried creating a new project and importing everything cited on this thread, but it still happens, even switch from 6.0.2 to 6.2.4. I'm testing using the latest xcode with macOS Ventura, with an apple M1. I'm not using Firebase, just the GoogleSignIn.

image

hi, @matbn do you delete what you import before and then import the .unitypackage provided in this thread?

CodeMasterYi avatar Jan 11 '23 13:01 CodeMasterYi

@CodeMasterYi yes, and I've also tried with a fresh project too, just importing the plugin-1.0.4, your files and the sample scene

matbn avatar Jan 11 '23 13:01 matbn

@CodeMasterYi yes, and I've also tried with a fresh project too, just importing the plugin-1.0.4, your files and the sample scene

[email protected] @Amrazyan unzip this file and try import this unity package that modified by me.

hi @matbn what about only importing the .unitypackage file provided in this thread? this package is exported from my project which is working well.

one more thing, it depends this plugin https://github.com/googlesamples/unity-jar-resolver/releases/tag/v1.2.175 and this plugin depends on cocopods which downloads the remote dependencies on iOS Player.

CodeMasterYi avatar Jan 12 '23 12:01 CodeMasterYi

@CodeMasterYi using only your package with the jar resolver I could build, thank you for the help and for the updates. I still haven't tried the sign-in cause I'm having a little problem with the plist thing (kinda new to apple), but will update after fix this.

matbn avatar Jan 13 '23 02:01 matbn

@matbn Glad to hear that. If there is any problem about this package, let me know.

CodeMasterYi avatar Jan 13 '23 03:01 CodeMasterYi

[email protected] @Amrazyan unzip this file and try import this unity package that modified by me.

Thanks a lot! I had the same error as MrKhan2022. It showed up out of nowhere! Your new package solved the problem! I am very grateful to you!

romas34 avatar Jan 16 '23 10:01 romas34

@romas34 BTW, I fired a release in my own fork. See the every beginning of this thread.

CodeMasterYi avatar Jan 16 '23 13:01 CodeMasterYi

Works great! Supports SignIn 6.2.4 well, which allows iOS pods to resolve as long as you don't have any pods that requires GTMSessionFetcher/Core > 3.0.

mikeohuo avatar Jan 20 '23 01:01 mikeohuo

안녕하세요, 이것을 빌드하려고 하는데 MrKhan과 비슷한 오류가 발생하는데 제 경우에는 다른 파일(GIDSignIn)이 있어서 새 프로젝트를 만들고 이 스레드에서 인용된 모든 항목을 가져오려고 했습니다. 6.0.2에서 6.2.4로 전환하더라도 여전히 발생합니다. Apple M1과 함께 macOS Ventura에서 최신 xcode를 사용하여 테스트하고 있습니다. 저는 Firebase를 사용하지 않고 GoogleSignIn만 사용하고 있습니다. 영상

안녕,@matbn 이전에 가져온 항목을 삭제한 다음 .unitypackage이 스레드에서 제공된 항목을 가져오나요?

Hi, I'm trying to build this, but I'm having a similar error to MrKhan, but in my case is another file (GIDSignIn), I've tried creating a new project and importing everything cited on this thread, but it still happens, even switch from 6.0.2 to 6.2.4. I'm testing using the latest xcode with macOS Ventura, with an apple M1. I'm not using Firebase, just the GoogleSignIn. image

hi, @matbn do you delete what you import before and then import the .unitypackage provided in this thread?

Hello I'm having the same problem. There is no problem with the Android build, but there was a problem during the iOS build process. I've been suffering from this problem for more than three days By any chance, is there a solution you can suggest? Please understand that I used a translator because I am not good at English.

wjdwltn200 avatar Mar 22 '23 17:03 wjdwltn200

@wjdwltn200 Remove all GoogleSignIn plugin files that you have imported into your project. Then DO what I say at the thread top.

CodeMasterYi avatar Mar 23 '23 08:03 CodeMasterYi

@wjdwltn200 Remove all GoogleSignIn plugin files that you have imported into your project. Then DO what I say at the thread top.

Unfortunately, I've tried the method that you already suggested Unfortunately, it didn't work. However, it works fine on Android, so I'm trying to find a new way Thank you for your reply.

wjdwltn200 avatar Mar 23 '23 08:03 wjdwltn200

@CodeMasterYi Hi, thank you on what you doing. I need some help In android I'm importing the external dependency manager (via link that you provided) then importing the package you provided here(GoogleSignin@JokerMaker) Resolving Importing GoogleSigninSample, putting my WebClientId building successfully but it throwing exception -> DeveoperError Exception of type 'Google.GoogleSignin+SigninException' was thrown

Amrazyan avatar Mar 23 '23 08:03 Amrazyan

Seems I needed to add my bundle id and generated SHA1 to google cloud

Amrazyan avatar Mar 23 '23 14:03 Amrazyan