google-maps-services-js icon indicating copy to clipboard operation
google-maps-services-js copied to clipboard

Add reviews_sort & reviews_no_translations to place details

Open wiredmatt opened this issue 1 year ago • 3 comments
trafficstars

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Code coverage does not decrease (if any source code was changed)
  • [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

I'll come back to work on this PR, in a rush atm. The sdk was missing the fields reviews_sort and reviews_no_translations.

wiredmatt avatar Jan 31 '24 13:01 wiredmatt

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 31 '24 13:01 google-cla[bot]

@wiredmatt are you still working on this one?

ABertaud avatar Jun 23 '24 16:06 ABertaud

@wiredmatt are you still working on this one?

Hi. I refuse to sign the required CLA. You may create a fork like I did and point your package.json dependency to resolve to your github fork.

wiredmatt avatar Jun 23 '24 17:06 wiredmatt