python-bigquery-pandas icon indicating copy to clipboard operation
python-bigquery-pandas copied to clipboard

Clean-up error handling to pass through errors instead of catching/rethrowing

Open tswast opened this issue 6 years ago • 3 comments
trafficstars

There have been several StackOverflow questions about GenericGBQException.

We should have a troubleshooting document that covers:

  • Common exceptions that may occur.
  • How to import them to catch them.
  • Best practices for handling them.

Side note: We may want to reconsider catching Google API exceptions at all and just letting them pass through.

tswast avatar Mar 26 '19 16:03 tswast

There have been several StackOverflow questions about GenericGBQException.

Awesome, great perception

Side note: We may want to reconsider catching Google API exceptions at all and just letting them pass through.

👍 Is there a compelling reason for catching and rethrowing?

max-sixty avatar Mar 26 '19 17:03 max-sixty

Is there a compelling reason for catching and rethrowing?

I'm having trouble thinking of one.

tswast avatar Mar 26 '19 17:03 tswast

Converting this to a feature request to pass through server-side errors instead of catching/handling them with custom exceptions.

meredithslota avatar Aug 23 '23 20:08 meredithslota