nodejs-spanner icon indicating copy to clipboard operation
nodejs-spanner copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

Generated samples are missing

Open fhinkel opened this issue 3 years ago • 3 comments
trafficstars

For example there's no sample with this referenced region tag: spanner_v1_generated_Spanner_BatchCreateSessions_async

This got merged but it looks somewhat wrong to me: https://github.com/googleapis/nodejs-spanner/pull/1484/files

fhinkel avatar Nov 24 '21 19:11 fhinkel

@sofisl Do we have any update on the autogenerated samples for Node js ?

surbhigarg92 avatar Sep 13 '22 05:09 surbhigarg92

@surbhigarg92, is this something the spanner team wants? https://github.com/googleapis/nodejs-spanner/blob/f1ae51301d4ea9b0ed1ad4d4762c249fef9f8d08/owlbot.py#L66

sofisl avatar Sep 15 '22 16:09 sofisl

@sofisl This was done intentionally to avoid autogenerated samples as we are not using autogenerated client , instead have an handwritten layer for same.

surbhigarg92 avatar Sep 20 '22 09:09 surbhigarg92