nodejs-firestore icon indicating copy to clipboard operation
nodejs-firestore copied to clipboard

fix: Remove @internal annotation from snapshot_

Open TheIronDev opened this issue 3 years ago • 1 comments
trafficstars

This commit removes the @internal annotation from snapshot_, and fixes https://github.com/firebase/firebase-functions-test/issues/87.

snapshot_ is currently referenced here.

More context here

I'm happy to work through better alternatives too.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x] Ensure the tests and linter pass
  • [x] Code coverage does not decrease (if any source code was changed)
  • [?] Appropriate docs were updated (if necessary)

Fixes https://github.com/firebase/firebase-functions-test/issues/79 🦕

TheIronDev avatar May 18 '22 20:05 TheIronDev

Is there an appropriate person I should ping for review? 🐼

TheIronDev avatar Sep 14 '22 13:09 TheIronDev