google-cloud-cpp
google-cloud-cpp copied to clipboard
refactor: simplify `*Connection` current policy getters
Google Cloud Build Logs
For commit: 19b09e49b875c92b9f4c915746518052222dbfa3
- Public Access Build Logs
- Cloud Build Console (requires auth)
- Kokoro Logs (requires auth)
:information_source: NOTE: Kokoro logs are linked from "Details" below.
Codecov Report
Merging #9673 (19b09e4) into main (9276075) will increase coverage by
0.00%. The diff coverage is99.09%.
@@ Coverage Diff @@
## main #9673 +/- ##
=======================================
Coverage 94.33% 94.34%
=======================================
Files 1494 1494
Lines 138961 139024 +63
=======================================
+ Hits 131089 131159 +70
+ Misses 7872 7865 -7
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...den/internal/golden_kitchen_sink_connection_impl.h | 50.00% <ø> (-27.78%) |
:arrow_down: |
| ...lden/internal/golden_thing_admin_connection_impl.h | 100.00% <ø> (ø) |
|
| generator/internal/connection_impl_generator.cc | 48.48% <66.66%> (ø) |
|
| ...en/internal/golden_kitchen_sink_connection_impl.cc | 78.21% <100.00%> (+2.93%) |
:arrow_up: |
| ...den/internal/golden_thing_admin_connection_impl.cc | 93.35% <100.00%> (+0.44%) |
:arrow_up: |
| ...olden/tests/golden_kitchen_sink_connection_test.cc | 98.77% <100.00%> (+0.09%) |
:arrow_up: |
| ...golden/tests/golden_thing_admin_connection_test.cc | 99.60% <100.00%> (+0.02%) |
:arrow_up: |
| ...bigtable/examples/bigtable_hello_instance_admin.cc | 81.00% <0.00%> (-2.00%) |
:arrow_down: |
| ...cloud/pubsub/internal/subscription_session_test.cc | 97.98% <0.00%> (-0.34%) |
:arrow_down: |
| google/cloud/pubsub/samples/samples.cc | 90.77% <0.00%> (+0.07%) |
:arrow_up: |
| ... and 4 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I am closing this PR, because I won't pick up the work any time soon. Maybe I will revisit it later.