fix: comment and uncompress data before loads

[b3g00d]

source code:

from google.oauth2 import _id_token_async as id_token
from google.auth.transport import _aiohttp_requests as requests


class GoogleClient:
    def __init__(self, client_id):
        self.req = requests.Request()
        self.client_id = client_id

    async def verify_token(self, token):
        id_info = await id_token.verify_token(token, self.req, self.client_id)
        return id_info

import unittest
from unittest import IsolatedAsyncioTestCase


class Test(IsolatedAsyncioTestCase):

    async def test_error_on_fetch_cert(self):
        g_c = GoogleClient("test")
        await g_c.verify_token("test_token")


if __name__ == "__main__":
    unittest.main()

It will raise error at function _fetch_certs because of the response return as a bytes array, but json.dumps(data) is trying to dumps the bytes array

ERROR: test_error_on_fetch_cert (__main__.Test)     
----------------------------------------------------------------------
Traceback (most recent call last):  
  File "/usr/lib/python3.8/unittest/async_case.py", line 65, in _callTestMethod                          
    self._callMaybeAsync(method)
  File "/usr/lib/python3.8/unittest/async_case.py", line 88, in _callMaybeAsync                          
    return self._asyncioTestLoop.run_until_complete(fut)                                              
  File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()                                                                               
  File "/usr/lib/python3.8/unittest/async_case.py", line 102, in _asyncioLoopRunner
    ret = await awaitable
  File "core/connections/google_client.py", line 22, in test_error_on_fetch_cert
    await g_c.verify_token("test_token")
  File "core/connections/google_client.py", line 11, in verify_token
    id_info = await id_token.verify_token(token, self.req, self.client_id)
  File "/home/begood/.local/share/virtualenvs/BE-fy1aetm7/lib/python3.8/site-packages/google/oauth2/_id_token_async.py", line 119, in verify_token
    certs = await _fetch_certs(request, certs_url)
  File "/home/begood/.local/share/virtualenvs/BE-fy1aetm7/lib/python3.8/site-packages/google/oauth2/_id_token_async.py", line 98, in _fetch_certs
    return json.loads(json.dumps(data)) 
  File "/usr/lib/python3.8/json/__init__.py", line 231, in dumps    
    return _default_encoder.encode(obj)                                                                  
  File "/usr/lib/python3.8/json/encoder.py", line 199, in encode                                                                                                                                                   
    chunks = self.iterencode(o, _one_shot=True)   
  File "/usr/lib/python3.8/json/encoder.py", line 257, in iterencode                                                                                                                                               
    return _iterencode(o, 0)                                                                             
  File "/usr/lib/python3.8/json/encoder.py", line 179, in default                                                                                                                                                  
    raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type bytes is not JSON serializable

I looked into the source code, and the response.content() work as expected.

[google-cla[bot]]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[b3g00d]

@googlebot I signed it!

[b3g00d]

The docstring changes look fine.

For the change to _fetch_certs, two things:

• Is there a bug report open for which this change is a fix? If not, can you please add one.
• We almost certainly need to make correspondng changes to tests.

@tseaver updated

[tseaver]

@b3g00d

updated

I don't see any further commits here, and I don't see a related issue.

[b3g00d]

@b3g00d

updated

I don't see any further commits here, and I don't see a related issue.

Oh, I mean I updated the first comment, should I put it to commit message.

[UlisseMini]

I had the same problem, changing

    data = await response.data.read()

    return json.loads(json.dumps(data))

to

    data = await response.content()

    return json.loads(data.decode('utf-8'))

Here fixes it, this is because auth/transport/_aiohttp_requests.py's _CombinedResponse has

    @property
    def data(self):
        return self._response.content

Which never uses _is_compressed to check for compression (unlike content).

I don't know why json.loads(json.dumps(data)) was there, it seems like a bad form of decoding.

The only test for .data is here which doesn't specify if it should decompress or not, the other tests are for .content() and .raw_content().