gax-nodejs icon indicating copy to clipboard operation
gax-nodejs copied to clipboard
verified publisher icon googleapis

Google cloud translate api does not honour request timeout

Open urjitbhatia opened this issue 2 years ago • 4 comments

Yes, see the PR here: https://github.com/googleapis/google-cloud-node/pull/3849 Google cloud translate api does not honour the request timeout in the patched request code.

  • OS: ubuntu
  • Node.js version: 18
  • npm version: (Yarn 1.22.4)
  • google-gax version: 3.5.2

Steps to reproduce

  1. Create a translate client.
  2. Set a request timeout
  3. Point request to a dummy server that takes long or set a really small timeout to test
  4. Request continues beyond the timeout and doesn't abort

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

urjitbhatia avatar Jan 19 '23 19:01 urjitbhatia

For more context, the bug is seen in the v2 translate client, we haven't verified whether the v3 client has this issue or not.

dbellizzi avatar Jan 19 '23 22:01 dbellizzi

CC: @leahecole, this may be adjacent to the retry work you're doing.

bcoe avatar Jan 31 '23 17:01 bcoe

I was just poking around gax issues again and at first glance, I'm not sure this is adjacent to the gax work because the v2 code linked does not call gax at all.

leahecole avatar May 22 '23 18:05 leahecole

Just to give you some details - Translate is a combined library, v2 is handwritten and v3* are GAPIC generated. Any issues with retries in v2 are likely coming from retry-request via @google-cloud/common (likely).

alexander-fenster avatar May 22 '23 22:05 alexander-fenster

Closing this as obsolete - if this is still an issue, Alex's previous comment about it coming from @google-cloud/common is right. If the v3 client is having an issue, feel free to lmk and I can upgrade it to use gax native retries instead.

leahecole avatar May 21 '24 20:05 leahecole