gapic-generator-java
gapic-generator-java copied to clipboard
feat: add comment to service client to disclose api version.
Follow-up to #2630 https://github.com/googleapis/sdk-platform-java/pull/2671.
This pr adds to service client composer to expose api-version via class comment.
Note: reverted api-version option in gapic-generator-java/src/test/proto/echo_grpcrest.proto, which was added by accident in #2671. All test related to api-version should use api_version_testing.proto instead.
Quality Gate passed for 'gapic-generator-java-root'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
Quality Gate passed for 'java_showcase_integration_tests'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Here is the summary of possible violations 😱
- gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/AsyncEchoWithVersionMethod.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_async - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncCreateSetCredentialsProvider.golden:19, tag
goldensample_generated_EchoWithVersion_Create_SetCredentialsProvider_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncCreateSetEndpoint.golden:19, tag
goldensample_generated_EchoWithVersion_Create_SetEndpoint_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethod.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodFoobarname.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_Foobarname_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodNoargs.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_Noargs_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodResourcename.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_Resourcename_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodStatus.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_Status_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodString.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_String_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodString1.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_String1_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodString2.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_String2_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodStringSeverity.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_StringSeverity_sync
The end of the violation section. All the stuff below is FYI purposes only.
Here is the summary of changes.
You are about to add 12 region tags.
- gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/AsyncEchoWithVersionMethod.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_async - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncCreateSetCredentialsProvider.golden:19, tag
goldensample_generated_EchoWithVersion_Create_SetCredentialsProvider_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncCreateSetEndpoint.golden:19, tag
goldensample_generated_EchoWithVersion_Create_SetEndpoint_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethod.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodFoobarname.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_Foobarname_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodNoargs.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_Noargs_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodResourcename.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_Resourcename_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodStatus.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_Status_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodString.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_String_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodString1.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_String1_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodString2.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_String2_sync - gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/apiversionclient/SyncEchoWithVersionMethodStringSeverity.golden:19, tag
goldensample_generated_EchoWithVersion_EchoWithVersionMethod_StringSeverity_sync
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment