gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

feat: add comment to service client to disclose api version.

Open zhumin8 opened this issue 1 year ago • 3 comments

Follow-up to #2630 https://github.com/googleapis/sdk-platform-java/pull/2671.

This pr adds to service client composer to expose api-version via class comment.

Note: reverted api-version option in gapic-generator-java/src/test/proto/echo_grpcrest.proto, which was added by accident in #2671. All test related to api-version should use api_version_testing.proto instead.

zhumin8 avatar Apr 24 '24 21:04 zhumin8

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 06 '24 06:05 sonarqubecloud[bot]

Here is the summary of possible violations 😱

There are 12 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 12 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar May 06 '24 07:05 snippet-bot[bot]