elixir-google-api icon indicating copy to clipboard operation
elixir-google-api copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

Allow poison 5.0.0 in gax

Open mopp opened this issue 3 years ago • 5 comments

Issues

  • https://github.com/googleapis/elixir-google-api/issues/8750

Overview

To merge the PR https://github.com/googleapis/elixir-google-api/pull/8251, we need to upgrade the poison in gax in advance. I just followed the past PR https://github.com/googleapis/elixir-google-api/pull/2888.

I confirmed that the tests passed on my local.

The supported elixir version of the Poison is ~> 1.11. But the supported elixir version of this library is ~> 1.6. I think 1.6 is too old and it's time to drop. However, I'm not sure what it does affect. then, I just keep the current implementation. https://github.com/devinus/poison/blob/e5c0867aaf3c9e9cb6da424580dcd8e1a25081d0/mix.exs#L14

@dazuma Could you review and release it?

mopp avatar Jan 31 '22 09:01 mopp

Hey @mopp , Any updates on getting this through yet?

wallarug avatar Jan 27 '23 01:01 wallarug

@wallarug hi! This PR is ready to be merged. But I don't have a privilege 😢 CC: @dazuma 🙏

mopp avatar Jan 30 '23 01:01 mopp

@dazuma ping 🙏 🙏 🙏

mopp avatar Mar 28 '23 02:03 mopp

Hey please could someone merge this PR?

hawkyre avatar Apr 07 '23 19:04 hawkyre

Hi, @metemaad can you please push this change forward, or point who could do that, I have a project that depends on this library, but is blocking the poison upgrade. 🙏🙏🙏 Thanks in advance.

jonatanrdsantos avatar Feb 04 '24 12:02 jonatanrdsantos