tensorflow-recorder icon indicating copy to clipboard operation
tensorflow-recorder copied to clipboard

Use lower case names for split values

Open cfezequiel opened this issue 5 years ago • 3 comments
trafficstars

Is your feature request related to a problem? Please describe. Change split values from all caps to lower case. This makes file/directory naming more consistent with the split.

Describe the solution you'd like TRAIN -> train VALIDATION -> validation TEST -> test

Describe alternatives you've considered

  1. No change
  • There's a bit of skew when it comes to mapping split value with file/dir name.

cfezequiel avatar Oct 14 '20 19:10 cfezequiel

@cfezequiel May you help me better understand what changes have to make ? I would love to contribute !

AnshuTrivedi avatar Oct 22 '20 01:10 AnshuTrivedi

Hi @AnshuTrivedi , thanks for the comment, and apologies for the delay in response. It seems I wasn't getting any notifications for non-PR comments in this repo (should be fixed now). Regarding this issue, the idea is to change the dataset split values that the tool uses from 'TRAIN', 'VALIDATION', 'TEST' to 'train', 'validation', 'test'. This would affect the following:

Input CSV/Pandas DataFrame: the split column should have train, 'validation', 'test' as acceptable values Input image directory: the image directory should now have the following structure

train/
  label0/
    image00
    ...
  label1/
  ...
validation/
  label0/
     ...
  ...
test/
  label0/
  ...

It's basically a cosmetic change. Let us know if you want to take this on.

cfezequiel avatar Nov 10 '20 18:11 cfezequiel

Hey @cfezequiel is this still open to do? I would be interested to do it.

Samad999777 avatar May 22 '21 13:05 Samad999777