tensorflow-recorder icon indicating copy to clipboard operation
tensorflow-recorder copied to clipboard

Code examples for using TFRecorder TFRecords in a tf.data.Dataset

Open mbernico opened this issue 5 years ago • 4 comments
trafficstars

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like As a user I would like to see an example of how to read the output of TFRecorder in as a tf.data.Dataset.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

mbernico avatar Aug 03 '20 21:08 mbernico

Hi @mbernico !, regarding the code examples in Jupyter Notebook documentation. A nice to have feature would be the ability to open them in a colab environment. Maybe adding a Badge like this Open In Colab .

thoughts? :)

jmarrietar avatar Sep 20 '20 15:09 jmarrietar

Hey jmarrietar, yeah, I think this makes a lot of sense. Would you mind adding it as a separate issue? Also if you wanted to pull request it we'd love that too, if not we can for sure get to it.

Lastly, would you mind taking a look at the flexible schema PR #20 I think it's useful, but it does make the codebase more complicated so I'd love some feedback before we merge it.

mbernico avatar Sep 20 '20 19:09 mbernico

Hey jmarrietar, yeah, I think this makes a lot of sense. Would you mind adding it as a separate issue? Also if you wanted to pull request it we'd love that too, if not we can for sure get to it.

Lastly, would you mind taking a look at the flexible schema PR #20 I think it's useful, but it does make the codebase more complicated so I'd love some feedback before we merge it.

Just created Issue https://github.com/google/tensorflow-recorder/issues/27 as a separated one. I didn't Assign it to me just yet since I might be short of time right now. But would like to take it soon. Cheers! :)

jmarrietar avatar Sep 22 '20 16:09 jmarrietar

Ok, cool, I put it in my name but feel free to take it on :)

mbernico avatar Sep 22 '20 17:09 mbernico