santa-tracker-web icon indicating copy to clipboard operation
santa-tracker-web copied to clipboard

Various Windows fixes

Open SneezingCactus opened this issue 4 years ago • 5 comments
trafficstars

Various fixes that make santa-tracker-web usable on Windows. It mostly fixes path issues.

SneezingCactus avatar Dec 02 '20 15:12 SneezingCactus

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Dec 02 '20 15:12 google-cla[bot]

@googlebot I signed it!

SneezingCactus avatar Dec 02 '20 15:12 SneezingCactus

@SneezingCactus thank you again for this fix. Some feedback:

  • can we keep using yargs.prefix but change its default value to be a path that makes sense on Windows?
  • similar for Closure, I wonder if we can keep the regex but normalize the input path to match it

I definitely want to get it in, I'm just concerned this breaks my dev flow a bit.

samthor avatar Dec 26 '20 01:12 samthor

I'll see what I can do to fix it

SneezingCactus avatar Dec 29 '20 22:12 SneezingCactus

The problem with yargs.prefix is that js files try to get files from static but repeats "../" way too much and it goes outside /st/ or whatever the prefix is. I can't fix those js files because they're compiled by google closure which changes the require paths.

One possible fix without removing yargs.prefix would be making static be accessible even without the prefix on, so for example, static could be accessed on both "localhost:8080/" and "localhost:8080/st/". It's quite hacky though.

Another possible fix would be changing google closure itself.

SneezingCactus avatar Dec 29 '20 22:12 SneezingCactus