santa-tracker-web
santa-tracker-web copied to clipboard
Various Windows fixes
Various fixes that make santa-tracker-web usable on Windows. It mostly fixes path issues.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@SneezingCactus thank you again for this fix. Some feedback:
- can we keep using
yargs.prefixbut change its default value to be a path that makes sense on Windows? - similar for Closure, I wonder if we can keep the regex but normalize the input path to match it
I definitely want to get it in, I'm just concerned this breaks my dev flow a bit.
I'll see what I can do to fix it
The problem with yargs.prefix is that js files try to get files from static but repeats "../" way too much and it goes outside /st/ or whatever the prefix is. I can't fix those js files because they're compiled by google closure which changes the require paths.
One possible fix without removing yargs.prefix would be making static be accessible even without the prefix on, so for example, static could be accessed on both "localhost:8080/" and "localhost:8080/st/". It's quite hacky though.
Another possible fix would be changing google closure itself.