python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

lint: configure pre-commit with Ruff

Open Borda opened this issue 1 year ago • 2 comments

reaction to https://github.com/google/python-fire/pull/549#issuecomment-2365220214

Switch from pylint to Ruff with the same rules to be applied the Ruff is implemented as pre-commit hook for simplicity

Borda avatar Sep 23 '24 12:09 Borda

Ah, we might actually need all the "# pylint: " directives for the google-internal fire codebase. Let's hold off on this.

dbieber avatar Sep 23 '24 15:09 dbieber

Ah, we might actually need all the "# pylint: " directives for the google-internal fire codebase. Let's hold off on this.

good to know, in such case would nee to keep pylint... :(

Borda avatar Oct 07 '24 10:10 Borda

@dbieber friendly ping if we shall land it or close it? :)

Borda avatar Feb 11 '25 12:02 Borda