python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

Fix pandas.DataFrame support in core._PrintResult

Open paul-ada opened this issue 2 years ago • 2 comments

  • and add HasCustomRepr check in value_types

Issue: When calling Fire on a function that returns a pd.DataFrame, the _PrintResult function in core.py prints the manual for DataFrames from the pandas Docs to stdout.

if value_types.HasCustomStr(result): doesn't recognize the DataFrame's custom __str__ as it is simply seemingly inherited from the custom __repr__ for DataFrames. See pandas.core.frame.DataFrame.__repr__ which calls .to_string()).

Due to this, the _PrintResult function displays the DataFrame's helptext.HelpText instead.

This implementation should fix the issue.

Edit: Only seeing now that there is a related issue: #274

paul-ada avatar Mar 31 '23 20:03 paul-ada

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 31 '23 20:03 google-cla[bot]

Thanks for the PR @paul-ada! It may be some time before we process it, but it is already appreciated.

dbieber avatar Jan 02 '24 21:01 dbieber