python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

ci: watcher for automerge

Open Borda opened this issue 2 years ago • 22 comments

As discussed in https://github.com/google/python-fire/pull/428#issuecomment-1413497193 adding a closure job would allow enabling automerge without need of updating branch protection checks when new Python version is added

Borda avatar Feb 02 '23 10:02 Borda

now we could set these two as required checks: image cc: @hugovk

Borda avatar Feb 02 '23 13:02 Borda

image

👍

hugovk avatar Feb 02 '23 15:02 hugovk

@dbieber any idea what is happening with the @copybara? as there are no details shared... :thinking:

Borda avatar Feb 07 '23 00:02 Borda

Copybara is the tool we use to sync the google internal copy of the repo with the github copy. The error could be from them getting out of sync; I'll have to look into that. You can ignore that check in the mean time.

dbieber avatar Feb 07 '23 15:02 dbieber

@dbieber how is it going? :chipmunk:

Borda avatar Feb 20 '23 18:02 Borda

@dbieber can I help with anything else here? :rabbit:

Borda avatar Mar 07 '23 14:03 Borda

Thanks for checking back in, but unfortunately no, no updates on my end.

dbieber avatar Mar 07 '23 15:03 dbieber

Gentle ping @dbieber :chipmunk:

Borda avatar Mar 24 '23 14:03 Borda

@dbieber how are you doing, still with this project? :chipmunk:

Borda avatar Sep 19 '23 12:09 Borda

hello @dbieber, happy New year! :fireworks:

Borda avatar Jan 02 '24 20:01 Borda

@dbieber any chance to get some more details on what is happening with the copybara?

Borda avatar Jan 09 '24 17:01 Borda

@dbieber any chance to get some more details on what is happening with the copybara?

Hmm, I don't know offhand. Copybara is a tool we use to sync our internal and external codebases. I'll have to investigate.

dbieber avatar Jan 09 '24 18:01 dbieber

I'll have to investigate.

lets try just restart it for now?

Borda avatar Jan 09 '24 18:01 Borda

You can safely ignore it.

dbieber avatar Jan 09 '24 18:01 dbieber

You can safely ignore it.

the rest is green :green_circle:

Borda avatar Jan 09 '24 18:01 Borda

@dbieber, so can we merge it? :thinking:

Borda avatar Feb 08 '24 14:02 Borda

Hi Borda,

Thank you for the PR and your patience. I see the value of running the GitHub Actions on a pull_request. I do not see the value of the watcher job or auto-merge, however.

I understand that the watcher job would allow for auto-merge. Perhaps I am misunderstanding what auto-merge is, but it seems to me that I would like to review and approve PRs before they are merged, and hence I do not want to enable auto-merge on this project. Let me know if I'm misunderstanding auto-merge or missing something.

Cheers, David

🐙

dbieber avatar Feb 24 '24 20:02 dbieber

I understand that the watcher job would allow for auto-merge.

That is probably a misunderstanding; the watcher jobs just aggregated the result over the previously completed matrix of jobs... so the case is that in the GH setting you do not need to click all jobs one by one and if you change Python version it need to be also updated in the setting but you set as required only this one which is aggregated result of all

Borda avatar Feb 24 '24 20:02 Borda

@dbieber, mind having a look and sharing your thoughts? 🦩 this will also be even more useful if we extend the testing matrix, ref #490

Borda avatar Apr 26 '24 12:04 Borda

@dbieber friendly ping if you could have a look... :chipmunk:

Borda avatar Jul 14 '24 13:07 Borda