python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

Published 20 hours ago • verified publisher icon google

adding code to support optional type abbreviation request

Open damienjburks opened this issue 3 years ago • 6 comments

Addresses #329

damienjburks avatar Jan 16 '22 00:01 damienjburks

@googlebot Could you please submit a rescan for the CLA? Thanks! image

damienjburks avatar Jan 16 '22 00:01 damienjburks

Added that adjustment. I wasn't aware that Union could have more than 2 options, so that you for the recommendation @genos

damienjburks avatar Jan 26 '22 15:01 damienjburks

Thanks for the contribution! This looks good. What Python versions does this support?

dbieber avatar Jan 29 '22 03:01 dbieber

@dbieber it supports python versions 3.x and up. I have not tested this with any of the python 2 versions.

Let me know if this is an issue.

damienjburks avatar Jan 29 '22 03:01 damienjburks

We don't need the improvement to apply to Python 2, but we do need to make sure we don't break fire for Python 2.7.

dbieber avatar Apr 16 '22 20:04 dbieber

@dbieber I will check into this, and attach my results to this issue. Thanks.

damienjburks avatar Apr 18 '22 17:04 damienjburks